feat(plugin): expose submit_feedback in both modes, add feedback flag#20
Draft
willleeney wants to merge 1 commit into
Draft
feat(plugin): expose submit_feedback in both modes, add feedback flag#20willleeney wants to merge 1 commit into
willleeney wants to merge 1 commit into
Conversation
The StackOne MCP server exposes submit_feedback on every account. The plugin now inherits it in both modes: - default mode: fetch_tools already returns it (kept available under provider/action filters by the SDK); - search_and_execute mode: _build_tools now appends it alongside tool_search/tool_execute. Adds a feedback flag (default True) threaded to both paths so callers can omit the feedback tool. Requires the stackone-ai SDK change that inherits submit_feedback from MCP and accepts the feedback kwarg. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The StackOne MCP server exposes
submit_feedbackas a global tool on every account (see unified-cloud-api PR #8507). The plugin now inherits it from the MCP catalog in both modes so A2A agents can report feedback:fetch_toolsalready returnssubmit_feedback(the SDK keeps it available under provider/action filters)._build_toolsnow appendssubmit_feedbackalongsidetool_search/tool_execute(from the catalog fetch it already does — no extra request).feedbackflag (defaultTrue) threaded to both paths so callers can omit the feedback tool.submit_feedbackfrom MCP, addsfeedbackkwarg).submit_feedbackMCP tool +/actions/rpcdispatch).Draft until those merge and the
stackone-aidependency is bumped.Test plan
pytest tests/test_plugin.py— updated call-signature assertions for the newfeedbackkwarg; added disable-feedback tests for both modes. 22 pass.E501(line 127, unrelated) left as-is.🤖 Generated with Claude Code
Summary by cubic
Expose the global submit_feedback tool from the StackOne MCP catalog in both plugin modes, with a new feedback flag to let callers opt out. This enables consistent feedback reporting for A2A agents.
New Features
fetch_tools(still respects provider/action filters)._build_toolsadds submit_feedback alongside tool_search/tool_execute (no extra requests).feedbackflag (default True) threads through both paths; set to False to omit the tool.Dependencies
stackone-ai-pythonupdate that inherits submit_feedback from MCP and supports thefeedbackkwarg.unified-cloud-apiexposing submit_feedback as a global MCP tool with RPC dispatch.Written for commit 9dd76e4. Summary will update on new commits.